Post
by Billsey » Sat 24.06.2006, 14:33
It now compiles, with the normal warnings. I suggest a few things.
Three warnings deal with functions undefined as extern, yet used as externs; in externs.h add these lines:
/* net-win.c */
extern int SetSocketNoDelay(int fd, int flag);
extern int SocketRead(int fd, char *buf, int size);
extern int CreateClientSocket(char *host, int port);
A third warning easily dealt with is in c-files.c. The function path_parse() doesn't have a return value if compiled for Windows and called with a '~' in the filename (impossible, I know). Just move the last return (0); outside the #endif and the warning will go away.
In main-win.c, the void function process_menus() has a return 0; in it, remove the 0.
In c-util.c, the function usleep is defined for Windows. It needs to return a value, I suggest 0.
Finally, you have changed the defaults for connecting to a server. As such, it never goes out to the meta-server to get a list of server names. The user is stuck unless he remembers the URL for the server to which he wants to connect. I suggest that a distributed version of this should use the standard meta-server when a server isn't specified in the config file, as the normal client does...
Other than that, it looks good so far. Great job!
Bill
Mangband Project Team Member